Disable ruff split-on-trailing-comma and update ruff #2544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
previously approved these changes
Feb 22, 2024
I agree. Reformatting back would be ideal, but if thats not an option I agree with reducing the noise in Pr's |
underdarknl
approved these changes
Feb 26, 2024
zcrt
pushed a commit
to zcrt/nl-kat-coordination
that referenced
this pull request
Feb 27, 2024
Co-authored-by: ammar92 <[email protected]> Co-authored-by: Jan Klopper <[email protected]>
jpbruinsslot
added a commit
that referenced
this pull request
Mar 5, 2024
* main: (85 commits) Fix wrong solving of merge conflict (#2585) Add metrics collection for scheduler using prometheus (#2468) Hotfix for where_in queries for abstract types (#2577) Update django (#2587) Fix octopoes typing (#2555) Create findings report (#2393) Raise exception if boefje input OOI has been deleted (#2573) Set a timeout on hanging test ssl container (#2560) Feature/efficient reporting (#2516) Updated findings database. Removed old findings, added Impact, Source… (#2569) add unit test for web report (#2528) Add pool size config and logs (#2541) Quick fix for PDF table overflow (#2562) Fix/2527 octopoes unicode (#2558) Add return typing to report test fixtures (#2557) Sort vulnerabilities in vulnerability report (#2378) Disable ruff split-on-trailing-comma and update ruff (#2544) Select all oois triggers toggle all (#2536) Remove unnecessary toplevel dependencies (#2554) Make valid time required parameter in the octopoes API (#2543) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See https://docs.astral.sh/ruff/settings/#lint_isort_split-on-trailing-comma
I see this cause unnecessary noise in PRs. Probably it is because if you add an import while coding, the line can be split because it gets too long, and if later the import is removed again it will not be folded back.
It also updates ruff and move the linting config to ruff.lint (this has been changed in ruff 0.2 because they also added a formatter)
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.