Select all oois triggers toggle all

[Rieven]

Changes

Select all oois button triggered toggle all, which is not necessary.

• When pressing the button "Continue with all OOIs", it will not continue, saying that there are no oois selected from the list of oois.
• This is because the button is in the same form as the oois selection (checkboxes)
• I move the button outside the form to seperate 2 submits.
• Test by clicking the button again and check whether it will continue to the next page (with no errors, see screenshot).

The problem

Pressing the button "Continue with all OOIs" cannot go to the next page, because it triggers the toggle all functionality in JS which requires at least 1 checkbox to be selected from the list of objects(OOIs). No selection is needed with "Continue with all OOIs".

"Continue with all OOIs" should go to the next page with query parameter : ooi="all" and should not be interrupted by the toggle all functionality.

Under what circumstances is this problem occurring?
screenshot:

Steps to reproduce

1. Go to Reports in main menu
2. Go to "Aggregate reports"
3. Press "Continue with all OOIs" and see error at toggle all checkbox (see screenshot)

Possible solutions

• Describe possible ways to solve the problem.
  Remove the button outside the ooi selection form and having its own form

What other options have you considered?
Put a href attribute, but then it also needs to continue with all the selection from query parameters, so need to refactor that as well.

Solution

Remove the button outside the ooi selection form and having its own form

---

Code Checklist

• All the commits in this PR are properly PGP-signed and verified.
• This PR only contains functionality relevant to the issue; tickets have been created for newly discovered issues.
• I have written unit tests for the changes or fixes I made.
• For any non-trivial functionality, I have added integration and/or end-to-end tests.
• I have performed a self-review of my code and refactored it to the best of my abilities.

Communication

• I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
• I have made corresponding changes to the documentation, if necessary.
• I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

---

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

---

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

[stephanie0x00]

Checklist for QA:

• I have checked out this branch, and successfully ran a fresh make reset.
• I confirmed that there are no unintended functional regressions in this branch:
  • I have managed to pass the onboarding flow
  • Objects and Findings are created properly
  • Tasks are created and completed properly
• I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

The code and check seem to work as expected. Nice explanation of what you are trying to fix with your PR! Ready for merge.

What doesn't work:

n/a

Bug or feature?:

n/a