Rename invalid rpki finding to expired #2377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammar92
approved these changes
Jan 25, 2024
underdarknl
approved these changes
Jan 25, 2024
dekkers
pushed a commit
that referenced
this pull request
Jan 25, 2024
Co-authored-by: Jan Klopper <[email protected]>
jpbruinsslot
added a commit
that referenced
this pull request
Jan 29, 2024
* main: Fix/394 Introduce clearance level control for objects imported by CSV (#2390) Update RabbitMQ to the latest version (#2392) Show created at and data from in reports (#2370) Rename invalid rpki finding to expired (#2377) Convert `docker-compose` to `docker compose` (#2341) Remove uWSGI (#2366) Prevent double github actions (#2374)
jpbruinsslot
added a commit
that referenced
this pull request
Jan 29, 2024
* main: Fix/394 Introduce clearance level control for objects imported by CSV (#2390) Update RabbitMQ to the latest version (#2392) Show created at and data from in reports (#2370) Rename invalid rpki finding to expired (#2377) Convert `docker-compose` to `docker compose` (#2341) Remove uWSGI (#2366) Prevent double github actions (#2374) Fix WEASYPRINT_BASEURL default value and change ports in docker-compose.yml (#2373) Remove debian11 packages (#2358) Error handling for Generate Report (#2274) Update dependencies (#2348) Add token authentication (#2349) Adds CAA records to the model, boefje, normalizer, adds a check bit and a finding (#2315) Check for sudo in install and update script (#2360) Feat/normalizer mimetype upload deeplink (#2220) Add hrefs to Basic Security overview (#2330) Render dicts and list ooi attrs as jsonfield (#2355)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changed the finding name to expired which better reflects what the boefje actually checks.
Issue link
Closes #2332
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
Code Checklist
Communication
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.