Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming RPKI findings from 'invalid' to 'not-expired' #2332

Closed
stephanie0x00 opened this issue Jan 15, 2024 · 1 comment · Fixed by #2377
Closed

Renaming RPKI findings from 'invalid' to 'not-expired' #2332

stephanie0x00 opened this issue Jan 15, 2024 · 1 comment · Fixed by #2377
Labels
bug Something isn't working

Comments

@stephanie0x00
Copy link
Contributor

As mentioned in #2255:

The corresponding finding is still named "KAT-INVALID-RPKI" instead of "KAT-NOTEXPIRED-RPKI". This should still be changed.

Reason for this is that the current RPKI boefje only checks if the RPKI is not expired, it doesn't perform any validity checks. See issue #2331 for that.

@stephanie0x00 stephanie0x00 added the bug Something isn't working label Jan 15, 2024
@noamblitz
Copy link
Contributor

Ill rename the finding to KAT-EXPIRED-RPKI instead of KAT-INVALID-RPKI (and not to KAT-NOTEXPIRED-RPKI) :)

@noamblitz noamblitz added this to KAT Jan 24, 2024
@noamblitz noamblitz moved this to Review in KAT Jan 24, 2024
@ammar92 ammar92 moved this from Review to Ready for merge in KAT Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Ready for merge to Done in KAT Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants