This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
task/COR-1320: New KPI tiles for hospital and care #4590
Merged
hasan-ozaynaci
merged 7 commits into
feature/COR-1275-hospital-icu-pages
from
task/cor-1320-hospital-kpi-tiles
Jan 4, 2023
Merged
task/COR-1320: New KPI tiles for hospital and care #4590
hasan-ozaynaci
merged 7 commits into
feature/COR-1275-hospital-icu-pages
from
task/cor-1320-hospital-kpi-tiles
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical
* task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]>
hasan-ozaynaci
requested review from
Jorrik-Klijnsma-Work and
VWSCoronaDashboard26
January 2, 2023 17:16
hasan-ozaynaci
changed the title
COR-1320: New KPI tiles for hospital and care
task/COR-1320: New KPI tiles for hospital and care
Jan 2, 2023
hasan-ozaynaci
force-pushed
the
task/cor-1320-hospital-kpi-tiles
branch
from
January 2, 2023 17:39
3e7a756
to
06e1123
Compare
packages/app/src/domain/hospital/hospitals-tile/hospitals-tile.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/hospital/hospitals-tile/hospitals-tile.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/domain/hospital/hospitals-tile/hospitals-tile.tsx
Outdated
Show resolved
Hide resolved
VWSCoronaDashboard26
force-pushed
the
feature/COR-1275-hospital-icu-pages
branch
from
January 3, 2023 15:26
1800d59
to
8a5f065
Compare
VWSCoronaDashboard26
force-pushed
the
task/cor-1320-hospital-kpi-tiles
branch
from
January 3, 2023 15:35
06e1123
to
3287812
Compare
hasan-ozaynaci
force-pushed
the
task/cor-1320-hospital-kpi-tiles
branch
from
January 4, 2023 09:18
3287812
to
d866028
Compare
…ws/nl-covid19-data-dashboard into feature/COR-1275-hospital-icu-pages
…-hospital-kpi-tiles
Amber-Taal-Work
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
VWSCoronaDashboard26
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG2M!
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Jan 17, 2023
* Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat: created new kpi tiles for hospital and care * feat: Adjust styling and optimized code * fix: added width to tile sections Co-authored-by: LR <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Jorrik-Klijnsma-Work
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat: created new kpi tiles for hospital and care * feat: Adjust styling and optimized code * fix: added width to tile sections Co-authored-by: LR <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]>
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Jan 31, 2023
* Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * task/COR-1320: New KPI tiles for hospital and care (#4590) * Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat: created new kpi tiles for hospital and care * feat: Adjust styling and optimized code * fix: added width to tile sections Co-authored-by: LR <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]> * task/COR-1321-restructure-and-add-graphs (#4589) * task(lcps/nice): updated HospitalsAndCarePage component to add new patient influx graphs for both hospitals and icus; Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feature(lcps/nice): applied PR feedback; cleaned up ChartTile and ChartTileHeader components; * feat(lcps/nice): updated bed occupancy graphs for both hospitals and ICUs to receive two new (individual) timelines; (#4606) Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat(lcps/nice): reverted some changes; satisfy compilation / typecheck again; * feat(lcps/nice): applied PR feedback and small design consistency changes; --------- Co-authored-by: HO <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hospitals and Care
pageinflux
logic to renderabsolute data
anddifferences
A before and after screenshots, both bed occupation and influxes
Before
After