This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
task/COR-1321-restructure-and-add-graphs #4589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWSCoronaDashboard26
requested review from
hasan-ozaynaci,
Jorrik-Klijnsma-Work and
Amber-Taal-Work
VWSCoronaDashboard26
force-pushed
the
feature/COR-1275-hospital-icu-pages
branch
from
1800d59 to
8a5f065
Compare
VWSCoronaDashboard26
force-pushed
the
task/COR-1321-restructure-and-add-graphs
branch
from
5935baf to
14b96cd
Compare
Amber-Taal-Work
approved these changes
Jan 4, 2023
…tient influx graphs for both hospitals and icus;
VWSCoronaDashboard26
force-pushed
the
task/COR-1321-restructure-and-add-graphs
branch
from
14b96cd to
d4994c0
Compare
hasan-ozaynaci
approved these changes
Jan 4, 2023
VWSCoronaDashboard26
deleted the
task/COR-1321-restructure-and-add-graphs
branch
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Jan 17, 2023
* task(lcps/nice): updated HospitalsAndCarePage component to add new patient influx graphs for both hospitals and icus; Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Jorrik-Klijnsma-Work
pushed a commit
that referenced
this pull request
Jan 30, 2023
* task(lcps/nice): updated HospitalsAndCarePage component to add new patient influx graphs for both hospitals and icus; Co-authored-by: VWSCoronaDashboard26 <[email protected]>
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Jan 31, 2023
* Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * task/COR-1320: New KPI tiles for hospital and care (#4590) * Feature/cor 1322 restructure pages (#4559) * wip: add new page structure * feat: added restructured page parts * feat: add combined graphs and adjust lokalize texts * feat: delete old page references on topical * task/COR-1323-lcps-nice-schema-updates (#4554) * task(schemas): updated hospital and icu LCPS schemas and generated data types Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat: created new kpi tiles for hospital and care * feat: Adjust styling and optimized code * fix: added width to tile sections Co-authored-by: LR <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]> * task/COR-1321-restructure-and-add-graphs (#4589) * task(lcps/nice): updated HospitalsAndCarePage component to add new patient influx graphs for both hospitals and icus; Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feature(lcps/nice): applied PR feedback; cleaned up ChartTile and ChartTileHeader components; * feat(lcps/nice): updated bed occupancy graphs for both hospitals and ICUs to receive two new (individual) timelines; (#4606) Co-authored-by: VWSCoronaDashboard26 <[email protected]> * feat(lcps/nice): reverted some changes; satisfy compilation / typecheck again; * feat(lcps/nice): applied PR feedback and small design consistency changes; --------- Co-authored-by: HO <[email protected]> Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
HospitalsAndCarePage(or 'Ziekenhuizen en de zorg' as it is called on the dashboard) page component to add new covid patient influx graphs for both hospitals and icus;influx_covid_patientsfor bothhospital_lcpsandintensive_care_lcps);Screenshot
Before
There is no before scenario for this graph as it is newly introduced.
After
Sanity
Sanity keys for the new graphs can be found in the following path inside Sanity studio:
Dashboard Pagina's > Ziekenhuizen en de zorg > nl.Sanity timelines for the new graphs can be found in the following path inside Sanity studio:
Datagerelateerde content > Elements > nl > hospital_lcps - Grafiek OR intensive_care_lcps - Grafiek(depending on which graph's timeline is relevant). New timelines are called 'Annotaties patiëteninstroom ziekenhuizen' and 'Annotaties patiënteninstroom intensive care'. An example is as below.