This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
feature/COR-1269-time-series-chart-y-axis-scaling #4551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it did not introduce any logic that did not already work but instead caused certain graphs on certain pages to not scale properly; removing the minimumRange prop will now facilitate automatic scaling on the y-axis of all time series charts;
VWSCoronaDashboard26
requested review from
hasan-ozaynaci,
Jorrik-Klijnsma-Work,
VWSCoronaDashboard25 and
APW26
Jorrik-Klijnsma-Work
approved these changes
Dec 21, 2022
VWSCoronaDashboard25
approved these changes
Dec 22, 2022
APW26
approved these changes
Dec 23, 2022
VWSCoronaDashboard26
deleted the
feature/COR-1269-time-series-chart-y-axis-scaling
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The aforementioned pull request introduced a new
minimumRangeproperty to all time series charts default to a value of10, yet also took the chart representing the R-number into account (which should hopefully never come anywhere near 10). However, this same pull request does not take charts into account in certain (possibly less visited) pages around the dashboard. Examples of these charts are in the list below. Rather than adding an override forminimumRangeto all these pages/charts, I opted to investigate if we could revert the introduction ofminimumRange. After this revert, and as such before the merge of the above pull request, all time series charts will use their OOTB logic to dynamically scale its y-axis based on the highest value inside the range of the series, meaningminimumRangecan be completely omitted.Examples of pages/charts that are affected by the introduction of
minimumRangeinclude but are not limited to: