This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Set minimum range for all graphs #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWSCoronaDashboard16
requested review from
VWSCoronaDashboard1,
VWSCoronaDashboard14 and
VWSCoronaDashboard17
VWSCoronaDashboard1
approved these changes
Nov 1, 2021
| * value it can find. This way we can catch the properties of both 'normal' | ||
| * values as well as grouped values (i.e. 'sewer per installation' or 'variants') | ||
| */ | ||
| type ValueKeys<T> = T extends ValuesMetric<infer V> ? ValueKeys<V> : keyof T; |
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Dec 21, 2022
… it did not introduce any logic that did not already work but instead caused certain graphs on certain pages to not scale properly; removing the minimumRange prop will now facilitate automatic scaling on the y-axis of all time series charts;
VWSCoronaDashboard26
added a commit
that referenced
this pull request
Dec 23, 2022
… it did not introduce any logic that did not already work but instead caused certain graphs on certain pages to not scale properly; removing the minimumRange prop will now facilitate automatic scaling on the y-axis of all time series charts; (#4551) Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the minimum range of all graphs 10, except for the R-number (since it will hopefully stay far away from 10 at all times)
Since exceptions will probably happen more often in the future, I made the minimum range configurable through metric configs. This way inline graphs can automatically pick up the right range as well. This needed some refinements to how we type data & metric configs. I made some utility types for our data which accommodate this, and replaced some repeated types through the codebase with these centralised utility types.