Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LNP-641-installed-and-configured-password-policy-module #637

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
### Checklist

- [ ] This PR contains **only** changes related to the above card
- [ ] This deployment has been tested [for cache invalidation](https://dsdmoj.atlassian.net/wiki/spaces/HUB/pages/3757342835/Caching+in+Drupal#Testing-if-a-deployment-will-stop-pages-being-served-from-cache)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

- [ ] Tests have been added/updated to cover the change
- [ ] Documentation has been updated where appropriate
- [ ] Tested in Development
1 change: 1 addition & 0 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"drupal/monolog": "^3",
"drupal/node_edit_protection": "^1.0",
"drupal/optgroup_taxonomy_select": "^1.2",
"drupal/password_policy": "^4.0",
"drupal/pathauto": "^1.8",
"drupal/pathologic": "^2",
"drupal/publication_date": "^2.0@beta",
Expand Down
498 changes: 285 additions & 213 deletions composer.lock

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions config/sync/admin_toolbar.settings.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we reintroducing this file? This module is no longer enabled and should not have any config.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
menu_depth: 4
4 changes: 3 additions & 1 deletion config/sync/claro.settings.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has nothing to do with password policy, and the shortcut module is no longer enabled.

Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
third_party_settings: { }
third_party_settings:
shortcut:
module_link: true
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ bundle: menu_link_content
label: 'Menu link title'
description: 'The text to be used for this link in the menu.'
required: true
translatable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nothing to do with your intended changes and undoes some of the already complete and deployed language changes.

I'm going to stop commenting on all the unintended changes here - see overall review comment.

translatable: false
default_value: { }
default_value_callback: ''
settings: { }
Expand Down
18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.help_page.changed.yml

This file was deleted.

18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.help_page.created.yml

This file was deleted.

20 changes: 0 additions & 20 deletions config/sync/core.base_field_override.node.help_page.menu_link.yml

This file was deleted.

20 changes: 0 additions & 20 deletions config/sync/core.base_field_override.node.help_page.path.yml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ bundle: help_page
label: 'Promoted to front page'
description: ''
required: false
translatable: false
translatable: true
default_value:
-
value: 0
Expand Down
18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.help_page.publish_on.yml

This file was deleted.

This file was deleted.

22 changes: 0 additions & 22 deletions config/sync/core.base_field_override.node.help_page.status.yml

This file was deleted.

22 changes: 0 additions & 22 deletions config/sync/core.base_field_override.node.help_page.sticky.yml

This file was deleted.

18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.help_page.title.yml

This file was deleted.

20 changes: 0 additions & 20 deletions config/sync/core.base_field_override.node.help_page.uid.yml

This file was deleted.

This file was deleted.

18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.homepage.changed.yml

This file was deleted.

18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.homepage.created.yml

This file was deleted.

20 changes: 0 additions & 20 deletions config/sync/core.base_field_override.node.homepage.menu_link.yml

This file was deleted.

20 changes: 0 additions & 20 deletions config/sync/core.base_field_override.node.homepage.path.yml

This file was deleted.

22 changes: 0 additions & 22 deletions config/sync/core.base_field_override.node.homepage.promote.yml

This file was deleted.

18 changes: 0 additions & 18 deletions config/sync/core.base_field_override.node.homepage.publish_on.yml

This file was deleted.

Loading