Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LNP-641-installed-and-configured-password-policy-module #637

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LNP-641-installed-and-configured-password-policy-module #637

wants to merge 2 commits into from

Conversation

sweetymj
Copy link
Contributor

@sweetymj sweetymj commented Dec 20, 2024 •
edited by jira bot
Loading

Context

Does this issue have a Jira ticket?
LNP-641
If this is an issue, do we have steps to reproduce?
N/A

Intent

What changes are introduced by this PR that correspond to the above card?

Installed and configured the Password Policy module

Would this PR benefit from screenshots?
N/A

Considerations

Is there any additional information that would help when reviewing this PR?
N/A
Are there any steps required when merging/deploying this PR?
N/A

Checklist

  • This PR contains only changes related to the above card
  • This deployment has been tested for cache invalidation
  • Tests have been added/updated to cover the change
  • Documentation has been updated where appropriate
  • Tested in Development

@sweetymj sweetymj requested a review from Eli-TW December 20, 2024 11:36
Eli-TW
Eli-TW requested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Eli-TW Eli-TW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shows problems from merging changes from other branches, many of which would be undone (HTTP tests, language configuration, etc, etc) if we were to merge this PR.

It will probably be easier to reapply your intended changes to a fresh branch from main with a recent make sync than unpick these changes here.

.github/pull_request_template.md
@@ -19,7 +19,6 @@
### Checklist

- [ ] This PR contains **only** changes related to the above card
- [ ] This deployment has been tested [for cache invalidation](https://dsdmoj.atlassian.net/wiki/spaces/HUB/pages/3757342835/Caching+in+Drupal#Testing-if-a-deployment-will-stop-pages-being-served-from-cache)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

config/sync/admin_toolbar.settings.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we reintroducing this file? This module is no longer enabled and should not have any config.

config/sync/claro.settings.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has nothing to do with password policy, and the shortcut module is no longer enabled.

Eli-TW
Eli-TW reviewed Dec 23, 2024
View reviewed changes
config/sync/core.base_field_override.menu_link_content.menu_link_content.title.yml
@@ -11,7 +11,7 @@ bundle: menu_link_content
label: 'Menu link title'
description: 'The text to be used for this link in the menu.'
required: true
translatable: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nothing to do with your intended changes and undoes some of the already complete and deployed language changes.

I'm going to stop commenting on all the unintended changes here - see overall review comment.

@Eli-TW Eli-TW added the do not merge This work is not at an appropriate stage to merge label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eli-TW Eli-TW Eli-TW requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
do not merge This work is not at an appropriate stage to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweetymj @Eli-TW