Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(example template): amending example template #979

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

murrlipp
Copy link
Contributor

@murrlipp murrlipp commented Dec 3, 2024

Related to #958

murrlipp and others added 5 commits December 3, 2024 15:08
…orrect size

On smaller screens the fixed height of the iframes often meant a lot of wasted whitespace.  This
commit adds and IFrameResizer class to dynamically size/resize the iframes according to the
contents.  This will dynamically update when the iframe content changes height using a
ResizeObserver. It will also resize when elements within the iframe change using a MutationObserver,
such as when the datepicker or buton menu pops up.
@murrlipp murrlipp added the staging:request Add this label to request a staging environment for a pull request label Dec 12, 2024
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request staging:active Automatic label added when the PR is on the staging environment labels Dec 12, 2024
@murrlipp murrlipp marked this pull request as ready for review December 12, 2024 14:01
@murrlipp murrlipp requested a review from a team as a code owner December 12, 2024 14:01
@murrlipp murrlipp mentioned this pull request Dec 12, 2024
6 tasks

<div class="app-tabs__panel app-tabs__panel--hidden" id="nunjucks-default-{{ id }}" role="tabpanel" aria-labelledby="tab_nunjucks-default-{{ id }}">

{% if arguments %}
<details class="govuk-details govuk-!-padding-3" data-module="govuk-details">
<details class="govuk-details " data-module="govuk-details">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, just spotted a space after the govuk-details class name. It is my last comment though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants