-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(example template): amending example template #979
Open
murrlipp
wants to merge
7
commits into
main
Choose a base branch
from
update-example-box
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+138
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrect size On smaller screens the fixed height of the iframes often meant a lot of wasted whitespace. This commit adds and IFrameResizer class to dynamically size/resize the iframes according to the contents. This will dynamically update when the iframe content changes height using a ResizeObserver. It will also resize when elements within the iframe change using a MutationObserver, such as when the datepicker or buton menu pops up.
…ggers size adjustment
murrlipp
added
the
staging:request
Add this label to request a staging environment for a pull request
label
Dec 12, 2024
🚀 Deploying to staging environment Username: |
github-actions
bot
added
staging:active
Automatic label added when the PR is on the staging environment
and removed
staging:request
Add this label to request a staging environment for a pull request
staging:active
Automatic label added when the PR is on the staging environment
labels
Dec 12, 2024
jbarnardmoj
reviewed
Dec 12, 2024
jbarnardmoj
reviewed
Dec 12, 2024
|
||
<div class="app-tabs__panel app-tabs__panel--hidden" id="nunjucks-default-{{ id }}" role="tabpanel" aria-labelledby="tab_nunjucks-default-{{ id }}"> | ||
|
||
{% if arguments %} | ||
<details class="govuk-details govuk-!-padding-3" data-module="govuk-details"> | ||
<details class="govuk-details " data-module="govuk-details"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, just spotted a space after the govuk-details class name. It is my last comment though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #958