Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coded example box improvements #958

Open
3 of 6 tasks
murrlipp opened this issue Nov 25, 2024 · 2 comments
Open
3 of 6 tasks

Coded example box improvements #958

murrlipp opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
maintenance A task that keeps the design system in tip-top shape

Comments

@murrlipp
Copy link
Contributor

murrlipp commented Nov 25, 2024

What

The coded example box template and associated HTML/Nunjucks/Figma tabs that appear on each component page would benefit from changes to make them more usable and clear.

Why

Whilst working on other tickets, @chrispymm and @murrlipp have identified some improvements to be made.

Tasks

  • Consider making wrapper for 'Open this example in a new window' full width so that examples aren't partially obscured when scrolling in examples.
  • Reconsider use of colour when HTML, Nunjucks and Figma tabs are active. There are currently multiple shades of grey that are very similar.
  • Reconsider use of grey as a background colour for tabbed content, now that the page background colour has been updated to grey.
  • Consider adding ability to set separate example box heights for desktop and mobile, so that example box heights aren't unnecessarily large when viewed on mobile.
  • Relay decisions to team.
  • Make changes and merge into main.

Who needs to be involved

  • Interaction Designer
  • Developer

Done

When the above tasks have been investigated, decisions made and updated in the appropriate templates.

@murrlipp murrlipp added the maintenance A task that keeps the design system in tip-top shape label Nov 25, 2024
@robertjmccarthy
Copy link
Contributor

Pulled this into Cycle 5. However, priority for the work is low so it should be pulled forward if capacity allows. If not, we'll move this ticket to Cycle 6 for prioritisation.

@murrlipp
Copy link
Contributor Author

murrlipp commented Dec 3, 2024

@chrispymm here's the branch: https://github.com/ministryofjustice/moj-frontend/tree/update-example-box

I haven't touched the following point:

  • Consider adding ability to set separate example box heights for desktop and mobile, so that example box heights aren't unnecessarily large when viewed on mobile.

And there's a strange styling quirk where a left and right border don't appear when the HTML tab is expanded. I can't see a reason for it, as discussed on Slack. If you're able to look at these two points that should be this ticket done.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance A task that keeps the design system in tip-top shape
Projects
Status: In Progress
Development

No branches or pull requests

3 participants