Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter toggle button): ensure button appears #581

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

gregtyler
Copy link
Contributor

@gregtyler gregtyler commented Mar 13, 2024

The container wasn't being wrapped in a jQuery tag, meaning the button wasn't properly appended to the DOM.

Use the jQuery-wrapped container instead.

@gregtyler gregtyler requested a review from a team as a code owner March 13, 2024 17:14
@gregtyler gregtyler added the staging:request Add this label to request a staging environment for a pull request label Mar 13, 2024
Copy link

🚀 Deploying to staging environment

Username: staging, Password: moj

@github-actions github-actions bot added staging:active Automatic label added when the PR is on the staging environment and removed staging:request Add this label to request a staging environment for a pull request labels Mar 13, 2024
The container wasn't being wrapped in a jQuery tag, meaning the button wasn't properly appended
to the DOM.

Use the jQuery-wrapped container instead.
@gregtyler gregtyler merged commit fbe6407 into main Mar 13, 2024
9 checks passed
@gregtyler gregtyler deleted the fix-filter-toggle-button branch March 13, 2024 18:01
gregtyler pushed a commit that referenced this pull request Mar 13, 2024
## [2.1.2](v2.1.1...v2.1.2) (2024-03-13)

### Bug Fixes

* **filter toggle button:** ensure button appears ([#581](#581)) ([fbe6407](fbe6407))
@gregtyler
Copy link
Contributor Author

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released staging:active Automatic label added when the PR is on the staging environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants