Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Upgrade: , , #295

Closed

Conversation

rohanssalunkhe
Copy link
Contributor

snyk-top-banner

Snyk has created this PR to upgrade multiple dependencies.

👯 The following dependencies are linked and will therefore be updated together.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.

Name Versions Released on

@azure/msal-common
from 14.13.0 to 14.14.2 | 4 versions ahead of your current version | 22 days ago
on 2024-08-28
@azure/msal-node
from 2.10.0 to 2.13.1 | 5 versions ahead of your current version | 22 days ago
on 2024-08-29
@ministryofjustice/frontend
from 2.1.1 to 2.2.0 | 3 versions ahead of your current version | 2 months ago
on 2024-07-31

Release notes
Package name: @azure/msal-common
  • 14.14.2 - 2024-08-28
  • 14.14.1 - 2024-08-13

    14.14.1

    Tue, 13 Aug 2024 23:25:08 GMT

    Patches

  • 14.14.0 - 2024-07-23
  • 14.13.1 - 2024-07-16
  • 14.13.0 - 2024-07-01
from @azure/msal-common GitHub release notes
Package name: @azure/msal-node
  • 2.13.1 - 2024-08-29
  • 2.13.0 - 2024-08-13

    2.13.0

    Tue, 13 Aug 2024 23:25:05 GMT

    Minor changes

    • Added file-based detection for Azure Arc ([email protected])
    • Bump @ azure/msal-common to v14.14.1 (beachball)
    • Bump eslint-config-msal to v0.0.0 (beachball)

    Patches

  • 2.12.0 - 2024-07-23

    2.12.0

    Tue, 23 Jul 2024 14:19:34 GMT

    Minor changes

    • Track MSAL node SKU for broker flows #7213 ([email protected])
    • Bump @ azure/msal-common to v14.14.0 (beachball)
    • Bump eslint-config-msal to v0.0.0 (beachball)
  • 2.11.1 - 2024-07-16
  • 2.11.0 - 2024-07-12
  • 2.10.0 - 2024-07-01
from @azure/msal-node GitHub release notes
Package name: @ministryofjustice/frontend from @ministryofjustice/frontend GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade:
  - @azure/msal-common from 14.13.0 to 14.14.2.
    See this package in npm: https://www.npmjs.com/package/@azure/msal-common
  - @azure/msal-node from 2.10.0 to 2.13.1.
    See this package in npm: https://www.npmjs.com/package/@azure/msal-node
  - @ministryofjustice/frontend from 2.1.1 to 2.2.0.
    See this package in npm: https://www.npmjs.com/package/@ministryofjustice/frontend

See this project in Snyk:
https://app.snyk.io/org/tanovellino/project/44a5dd0b-21d5-4c80-81e2-56c897479301?utm_source=github&utm_medium=referral&page=upgrade-pr
"@azure/msal-node": "^2.10.0",
"@ministryofjustice/frontend": "^2.1.1",
"@azure/msal-common": "^14.14.2",
"@azure/msal-node": "^2.13.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to msal-node v2.13.x breaks the application with the following error:-

[Node] TypeError: Cannot read properties of undefined (reading 'LogLevel')
[Node]     at Object.<anonymous> (/Users/.../Projects/laa-crime-equinity-historical-data-frontend/dist/server/auth/authConfig.js:27:43)
[Node]     at Module._compile (node:internal/modules/cjs/loader:1376:14)
[Node]     at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
[Node]     at Module.load (node:internal/modules/cjs/loader:1207:32)
[Node]     at Module._load (node:internal/modules/cjs/loader:1023:12)
[Node]     at Module.require (node:internal/modules/cjs/loader:1235:19)
[Node]     at Module.patchedRequire (/Users/.../Projects/laa-crime-equinity-historical-data-frontend/node_modules/diagnostic-channel/dist/src/patchRequire.js:16:46)
[Node]     at Hook._require.Module.require (/Users/.../Projects/laa-crime-equinity-historical-data-frontend/node_modules/require-in-the-middle/index.js:188:39)
[Node]     at require (node:internal/modules/helpers:176:18)
[Node]     at Object.<anonymous> (/Users/.../Projects/laa-crime-equinity-historical-data-frontend/dist/server/auth/authProvider.js:31:22)

Need to investigate this before upgrading library.

@muyinatech
Copy link
Collaborator

Closing as msal-node upgrade requires further investigation. Added comments to JIRA ticket:- https://dsdmoj.atlassian.net/browse/EMP-544

@muyinatech muyinatech closed this Sep 20, 2024
@muyinatech muyinatech deleted the snyk-upgrade-e30213ba9cdd905958ee4aa0ad90d927 branch November 5, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sortable table sort bugs
3 participants