fix(filter): ensure the clear link is shown #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent `font-size:0` rule was cascading to the clear link, meaning it wasn't shown. By adding an explicit font size to it, we can ensure it is shown. BREAKING CHANGE: Clear links will now be shown on Filter components. fix #274
gregtyler
force-pushed
the
fix-filter-clear-link-hidden
branch
from
0595b0d
to
0f9ef44
Compare
johnnolan
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent
font-size:0rule was cascading to the clear link, meaning it wasn't shown. By adding anexplicit font size to it, we can ensure it is shown.
fixes #274