-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear filters anchor not visible (font size inherited to be 0) #274
Comments
Thanks @commitBlob, good spot! I think a slightly cleaner fix would be to add |
gregtyler
added a commit
that referenced
this issue
Oct 22, 2021
The parent `font-size:0` rule was cascading to the clear link, meaning it wasn't shown. By adding an explicit font size to it, we can ensure it is shown. fix #274
gregtyler
added a commit
that referenced
this issue
Oct 22, 2021
The parent `font-size:0` rule was cascading to the clear link, meaning it wasn't shown. By adding an explicit font size to it, we can ensure it is shown. BREAKING CHANGE: Clear links will now be shown on Filter components. fix #274
Thanks Greg, agreed setting font size seems like a cleaner fix. |
gregtyler
added a commit
that referenced
this issue
Oct 26, 2021
The parent `font-size:0` rule was cascading to the clear link, meaning it wasn't shown. By adding an explicit font size to it, we can ensure it is shown. BREAKING CHANGE: Clear links will now be shown on Filter components. fix #274
gregtyler
pushed a commit
that referenced
this issue
Oct 26, 2021
# [1.0.0](v0.2.6-alpha...v1.0.0-alpha) (2021-10-26) ### Bug Fixes * **filter:** ensure the clear link is shown ([4c23cbd](4c23cbd)), closes [#274](#274) ### BREAKING CHANGES * **filter:** Clear links will now be shown on Filter components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Description
Clear filters anchor is not visible as font-size is inherited from the
moj-filter__selected-heading
class wherefont-size: 0;
. As anchor is wrapped with the paragraph tag it inherits font size from the parent.Steps to Reproduce
Expected behaviour:
Expected to see Clear filters anchor right of the Selected Filter header
Actual behaviour:
Clear filter anchor is not visible on the page
Reproduces how often:
100%
Versions
Was able to replicate the issue on the MoJ Pattern Library website as well as locally.
Local settings:
OS Version - Windows 10 Enterprise 21H1
Chrome - Version 94.0.4606.81 (Official Build) (64-bit)
@ministryofjustice/frontend package - 0.2.6
Node.js - v14.17.0
Additional Information
Adding a class such as
govuk-body
to the paragraph wrapping the anchor tag displayed element successfully.The text was updated successfully, but these errors were encountered: