Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename platform_versions.tf to versions.tf #8492

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dms1981
Copy link
Contributor

@dms1981 dms1981 commented Nov 15, 2024

A reference to the issue / Description of it

#8272

How does this PR fix the problem?

Renames our template files from platform_versions.tf to versions.tf. This will mean that the copied files are no longer subject to the **/platform_*.tf @ministryofjustice/modernisation-platform glob pattern in our CODEOWNERS file.

How has this been tested?

Confirmed that scripts used to provision member directories will still copy the renamed files.

Deployment Plan / Instructions

No deployment required. A following PR will rename platform_versions.tf to versions.tf in the Modernisation Platform repository.

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

…d by customers without Modernisation Platform oversight
@dms1981 dms1981 requested a review from a team as a code owner November 15, 2024 08:25
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/templates/modernisation-platform-environments-isolated
terraform/templates/modernisation-platform-environments


Running Trivy in terraform/templates/modernisation-platform-environments-isolated
Skipping folder as path name contains templates


Running Trivy in terraform/templates/modernisation-platform-environments
Skipping folder as path name contains templates

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/templates/modernisation-platform-environments-isolated
terraform/templates/modernisation-platform-environments

*****************************

Running Checkov in terraform/templates/modernisation-platform-environments-isolated
Skipping folder as path name contains *templates*

*****************************

Running Checkov in terraform/templates/modernisation-platform-environments
Skipping folder as path name contains *templates*

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/templates/modernisation-platform-environments-isolated
terraform/templates/modernisation-platform-environments

*****************************

Running tflint in terraform/templates/modernisation-platform-environments-isolated
Skipping folder as path name contains *templates*
tflint_exitcode=0

*****************************

Running tflint in terraform/templates/modernisation-platform-environments
Skipping folder as path name contains *templates*
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/templates/modernisation-platform-environments-isolated
terraform/templates/modernisation-platform-environments

*****************************

Running Trivy in terraform/templates/modernisation-platform-environments-isolated
Skipping folder as path name contains *templates*

*****************************

Running Trivy in terraform/templates/modernisation-platform-environments
Skipping folder as path name contains *templates*

@dms1981 dms1981 enabled auto-merge November 15, 2024 08:35
Copy link
Contributor

@richgreen-moj richgreen-moj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dms1981 dms1981 added this pull request to the merge queue Nov 15, 2024
@dms1981 dms1981 merged commit e22aa8e into main Nov 15, 2024
4 checks passed
@dms1981 dms1981 deleted the feature/8272-rename-platform_versions-in-templates branch November 15, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants