Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we allow members to add their own Terraform providers? #8272

Closed
5 tasks done
dms1981 opened this issue Oct 16, 2024 · 3 comments
Closed
5 tasks done

Can we allow members to add their own Terraform providers? #8272

dms1981 opened this issue Oct 16, 2024 · 3 comments
Assignees
Labels
member request Feature requested by a member to enhance the platform experience terraform Pull requests that update Terraform code

Comments

@dms1981
Copy link
Contributor

dms1981 commented Oct 16, 2024

User Story

As a Modernisation Platform Customer
I need to add providers to my terraform { required_providers { ... } }
So that I can supply providers that my code requires

Value / Purpose

Modernisation Platform customers have an ongoing need to manage their own terraform code, including specifying their own providers and versions. At present the only location that they can specify the relevant providers is in the platform_versions.tf file which is created from a standard template.

There is a risk that this file can be overwritten by a script in the Modernisation Platform repository - replace-platform-files-with-templates.sh.

We should find a way to allow customers to specify their own providers as they require.

Useful Contacts

No response

Additional Information

No response

Definition of Done

  • Assess possible options
    • Should we refactor platform_versions.tf to versions.tf and update our templates?
    • Should we just remove platform_versions.tf from the overwrite script?
    • Would we need to update the CODEOWNERS file to allow customer management without our oversight?
  • Chosen option implemented
@dms1981
Copy link
Contributor Author

dms1981 commented Oct 16, 2024

I think it's worth pointing out here that customers can define providers separately in modules, so keeping this gated doesn't give us the control that we might think it does. Personally I think this should be open to customers to adjust as their infrastructure requires.

@dms1981 dms1981 added terraform Pull requests that update Terraform code member request Feature requested by a member to enhance the platform experience labels Oct 16, 2024
@dms1981 dms1981 self-assigned this Nov 14, 2024
@dms1981
Copy link
Contributor Author

dms1981 commented Nov 15, 2024

@davidkelliott has previously solved the potential for platform_versions.tf to be overwritten in this PR. Once I've refactored the templates and the existing platform_versions.tf I'll remove this clause from the script.

@mikereiddigital
Copy link
Contributor

I've reviewed this issue & moving to done.

@mikereiddigital mikereiddigital moved this from For Review to Done in Modernisation Platform Nov 22, 2024
@mikereiddigital mikereiddigital closed this as completed by moving to Done in Modernisation Platform Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
member request Feature requested by a member to enhance the platform experience terraform Pull requests that update Terraform code
Projects
Status: Done
Development

No branches or pull requests

3 participants