Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting tariff ID #6550

Closed
wants to merge 3 commits into from
Closed

Deleting tariff ID #6550

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
038116f
Deleting tariff ID
SteveLinden Jun 12, 2024
cace4e9
Delete .github/workflows/reusable_terraform_plan_apply.yml
SteveLinden Jun 12, 2024
7f54963
Merge branch 'main' into delete-tariff-1718190843
richgreen-moj Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/reusable_terraform_plan_apply.yml
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be in your PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. I will try to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be trying to remove this altogether rather than from this PR.
I'll see if I can draw this back into the repo and try to remove it from there

Original file line number Diff line number Diff line change
Expand Up @@ -230,14 +230,16 @@ jobs:
core.notice('Pull request approved by a member of @ministryofjustice/modernisation-platform');
}
else {
core.setFailed('Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance');
core.setFailed('Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance'
# NEW code here);

await github.rest.pulls.createReview({
owner: context.repo.owner,
repo: context.repo.repo,
pull_number: context.payload.pull_request.number,
event: 'REQUEST_CHANGES',
body: 'Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance'
# NEW code here
});
}

Expand All @@ -256,6 +258,7 @@ jobs:
repo: repo,
issue_number: context.payload.pull_request.number,
body: `@${context.actor} Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance`
# NEW code here
});

apply:
Expand Down
66 changes: 0 additions & 66 deletions .github/workflows/tariff.yml
View file
Open in desktop

This file was deleted.

76 changes: 0 additions & 76 deletions terraform/environments/tariff/README.md
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions terraform/environments/tariff/application_variables.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion terraform/environments/tariff/data.tf
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion terraform/environments/tariff/locals.tf
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions terraform/environments/tariff/networking.auto.tfvars.json
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions terraform/environments/tariff/platform_backend.tf
View file
Open in desktop

This file was deleted.

11 changes: 0 additions & 11 deletions terraform/environments/tariff/platform_base_variables.tf
View file
Open in desktop

This file was deleted.

Loading