Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting tariff ID #6550

Closed
wants to merge 3 commits into from
Closed

Deleting tariff ID #6550

wants to merge 3 commits into from

Conversation

SteveLinden
Copy link
Contributor

To remove an account that is no longer needed

@SteveLinden SteveLinden requested review from a team as code owners June 12, 2024 14:54
@github-actions github-actions bot added environments-repository Used to exclude PRs from this repo in our Slack PR update github-workflow labels Jun 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/tariff

Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/tariff

*****************************

Running Checkov in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

CTFLint Scan Success

Show Output 
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
terraform/environments/tariff

*****************************

Running tflint in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.
tflint_exitcode=0

Trivy Scan Success

Show Output 
*****************************

Trivy will check the following folders:
terraform/environments/tariff

*****************************

Running Trivy in terraform/environments/tariff
Skipping folder terraform/environments/tariff as it does not exist.

dms1981
dms1981 reviewed Jun 12, 2024
View reviewed changes
.github/workflows/reusable_terraform_plan_apply.yml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this file be in your PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not. I will try to remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be trying to remove this altogether rather than from this PR.
I'll see if I can draw this back into the repo and try to remove it from there

@SteveLinden SteveLinden reopened this Jun 12, 2024
@SteveLinden SteveLinden reopened this Jun 12, 2024
@SteveLinden SteveLinden reopened this Jun 12, 2024
@SteveLinden SteveLinden reopened this Jun 13, 2024
@richgreen-moj richgreen-moj requested review from a team as code owners June 13, 2024 10:47
@richgreen-moj richgreen-moj requested review from a team as code owners June 13, 2024 10:47
@richgreen-moj richgreen-moj had a problem deploying to nomis-combined-reporting-development June 13, 2024 10:48 — with GitHub Actions Error
@richgreen-moj richgreen-moj had a problem deploying to hmpps-domain-services-development June 13, 2024 10:49 — with GitHub Actions Failure
@richgreen-moj richgreen-moj had a problem deploying to hmpps-domain-services-test June 13, 2024 10:49 — with GitHub Actions Failure
modernisation-platform-ci
modernisation-platform-ci requested changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@modernisation-platform-ci modernisation-platform-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected changes to resources that require approval from @ministryofjustice/modernsation-platform - please contact #ask-modernisation-platform for assistance

@modernisation-platform-ci
Copy link
Contributor

@richgreen-moj Terraform plan evaluation detected changes to resources that require approval from a member of @ministryofjustice/modernisation-platform - please contact #ask-modernisation-platform for assistance

@richgreen-moj richgreen-moj had a problem deploying to nomis-combined-reporting-test June 13, 2024 10:49 — with GitHub Actions Error
@richgreen-moj richgreen-moj had a problem deploying to delius-mis-development June 13, 2024 10:49 — with GitHub Actions Error
@richgreen-moj richgreen-moj had a problem deploying to analytical-platform-compute-test June 13, 2024 10:49 — with GitHub Actions Failure
@richgreen-moj richgreen-moj had a problem deploying to oasys-national-reporting-test June 13, 2024 10:49 — with GitHub Actions Failure
@richgreen-moj richgreen-moj had a problem deploying to analytical-platform-compute-development June 13, 2024 10:49 — with GitHub Actions Failure
@richgreen-moj richgreen-moj had a problem deploying to observability-platform-development June 13, 2024 10:49 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dms1981 dms1981 dms1981 left review comments

@modernisation-platform-ci modernisation-platform-ci modernisation-platform-ci requested changes

Assignees
No one assigned
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update github-workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SteveLinden @modernisation-platform-ci @dms1981 @richgreen-moj