Relax tls limitation on UI that blocks encryption if not enabled #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failing test might be fixed in #2194 |
|
🔥 |
cesnietor
force-pushed
the
relax-tls-limitation
branch
from
1de181a to
5bd805b
Compare
harshavardhana
approved these changes
Jul 4, 2024
|
this PR is on review, @r-scheele will be doing the validation |
|
@cesnietor the UI still is not allowing to disable TLS These are the steps i followed to test the pr To regenerated the console javascripts $ make assets
Building frontend static assets to 'build'
Creating an optimized production build...
Compiled successfully.Export the operator image. $ make installAnd then installed the operator/console |
|
Please rebase with master @cesnietor |
|
closing due to #2205 |
🍨 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2191
CRD still allows you to disable tls while having encryption as well as the Edit UI.
Seems that Operator already takes care of the TLS creation if encryption is enabled for KES regardless of whether it's enabled for the tenant or not see here.
This limitation was added on https://github.com/minio/console/pull/540/files#diff-3b60b0a032620e5fa1a8b8dc39485f0f82aef9356f58e5160734851c568c60c9R1168 but there doesn't seem to be a reason on why this was added.
Same limitation is done in backend.
Test Steps: