Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow enable at-rest Encryption without request for in-transit TLS in Operator UI #2191

Closed
pjuarezd opened this issue Jul 2, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@pjuarezd
Copy link
Member

pjuarezd commented Jul 2, 2024

Operator Console is not allowing to set Encryption (at rest) unless TLS and encryption in-transit (autocert or custom certificates) is enabled.

Would be better to allow Encryption in-rest regardless of encryption in transit is enabled or not.

It seems that this is solely a problem in the UI, since most likelly the CRD would allow to enable encyption without this restriction.

Describe alternatives you've considered
Use CRD instead

Additional context

encryption.no.tls.mov
@pjuarezd pjuarezd added the enhancement New feature or request label Jul 2, 2024
@pjuarezd pjuarezd changed the title Allow enable at-rest Encryption without request for in-transit TLS in UI Allow enable at-rest Encryption without request for in-transit TLS in Operator UI Jul 2, 2024
@pjuarezd
Copy link
Member Author

pjuarezd commented Jul 2, 2024

I will test when you have the UI change @cesnietor

@pjuarezd
Copy link
Member Author

pjuarezd commented Jul 5, 2024

@aead just pointed out that TLS (https) is required, https://docs.aws.amazon.com/AmazonS3/latest/userguide/UsingKMSEncryption.html

All GET and PUT requests for AWS KMS encrypted objects must be made using Secure Sockets Layer (SSL) or Transport Layer Security (TLS). Requests must also be signed using valid credentials, such as AWS Signature Version 4 (or AWS Signature Version 2).

Maybe this change is not needed

@pjuarezd
Copy link
Member Author

pjuarezd commented Jul 5, 2024

We discussed this internally,

SSE-C only mandates TLS
SSE-S3 and SSE-KMS do not require any TLS on the wire

Allow enable at-rest Encryption without request for in-transit is still valid
fyi @cesnietor @aead

@cesnietor
Copy link
Contributor

@pjuarezd so in summary how should the UI experience look like?

@pjuarezd
Copy link
Member Author

pjuarezd commented Jul 5, 2024

@pjuarezd so in summary how should the UI experience look like?

changes requested in this issue are still valid and is the expected final result, hesistated for a moment but we are fine.

@cesnietor
Copy link
Contributor

closing this since operator ui has been deprecated, see https://github.com/minio/operator/blob/master/docs/notes/v6.0.0.md#whats-new for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants