Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container security context to tenant crd and helm chart #1349

Conversation

LeadingMoominExpert
Copy link

Hi folks! With this PR I'm trying to address the issue described in here #1267 & #1310

Currently there is no way to pass full container level security context when deploying a tenant. This feature would be similar to the one pending for the operator and the console #1278

This is my first trying contributing here, so any pointers on what I'm missing here are more than welcome.

@dilverse
Copy link
Member

@LeadingMoominExpert did you get a chance to test this changes with Kubernetes version 1.20/1.21?

@dvaldivia
Copy link
Collaborator

I think we should add this on a per Pool basis similar to the already existing SecurityContext which gets applied to the Pod only across all the pods in the pool.

@LeadingMoominExpert
Copy link
Author

LeadingMoominExpert commented Dec 14, 2022

@LeadingMoominExpert did you get a chance to test this changes with Kubernetes version 1.20/1.21?

I did not, no. Which versions I should check for, up from 1.20?

@dilverse
Copy link
Member

@LeadingMoominExpert Thanks for your contribution, this issue is addressed in a much robust way in PR #1372. Will close this PR

@dilverse dilverse closed this Dec 22, 2022
@LeadingMoominExpert LeadingMoominExpert deleted the container-security-context branch December 29, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants