Add containerSecurityContext to helm charts #1278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Young <[email protected]>
harshavardhana
requested changes
Sep 5, 2022
Signed-off-by: David Young <[email protected]>
|
Hi @funkypenguin thanks for sending this PR! Based on our testing we identified this change breaks Kubernetes 1.21 and we have support up to Kubernetes 1.20. Many of the customers still use Kubernetes 1.21. Once Kubernetes 1.26/1.27 is out we will merge it |
harshavardhana
requested changes
Oct 5, 2022
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| description: A Helm chart for MinIO Operator | |||
| name: operator | |||
| version: 4.5.0 | |||
| version: 4.4.28 | |||
There was a problem hiding this comment.
you shouldn't be changing these @funkypenguin
|
I think this PR failed due to |
|
Fixed in #1372. Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
For your consideration, a PR to introduce containerSecurityContexts to the operator/console deployments.
Why?
Some security mitigations can only be applied within the context of the container spec (such as dropping capabilities, or preventing privileged mode), and without the ability to configure a container securityContext, validation / security assessment tools such as Kyverno will raise exceptions for operator/console.
Example below: