Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generic itens and blank cluster #171

Merged
merged 10 commits into from
Jun 2, 2020
Merged

Added generic itens and blank cluster #171

merged 10 commits into from
Jun 2, 2020

Conversation

leandrodamascena
Copy link
Contributor

Generic itens

image

Blank cluster
image

from diagrams import Cluster, Diagram
from diagrams.generic.blank import Blank
from diagrams.generic.network import *
from diagrams.generic.compute import *
from diagrams.generic.place import *

with Diagram(name="NEW Pull Request", show=True, direction="TB"):

 
    with Cluster("AWS"):
    
        blank = Blank("")
        
        firewall = Firewall("Firewall")
        
        rack = Rack("Rack")
        
        storage = Storage("Storage")
        
        router = Router("Router")
        vpn = VPN("VPN")
        switch = Switch("Switch")
        
        place = Datacenter("Datacenter")

@leandrodamascena leandrodamascena changed the title New PR with generic itens and blank cluster Added generic itens and blank cluster May 25, 2020
@mingrammer
Copy link
Owner

Storage should be under the generic.storage I think.

@mingrammer mingrammer added kind/feat/provider Provider request comp/node Issue of node component labels May 31, 2020
@leandrodamascena
Copy link
Contributor Author

Ok @mingrammer. Please check now!

@mingrammer
Copy link
Owner

Related: #126

mingrammer
mingrammer approved these changes Jun 2, 2020
View reviewed changes
Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you :). I'll add more generic icons on it! Rel: #126

@mingrammer mingrammer merged commit 97d73ac into mingrammer:master Jun 2, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
@nlamirault
Merge branch 'master' into feature/elasticstack
bc3d020 
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
@nlamirault
Merge branch 'master' into feature/tekton
4557141 
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
@aaronsteers aaronsteers mentioned this pull request Sep 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingrammer mingrammer mingrammer approved these changes

Assignees
No one assigned
Labels
comp/node Issue of node component kind/feat/provider Provider request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrodamascena @mingrammer