Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitlabCI to onprem.ci section #166

Merged
merged 1 commit into from
May 23, 2020

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented May 22, 2020

No description provided.

@mingrammer
Copy link
Owner

mingrammer commented May 23, 2020

The logo only image would be better. WDYT?

You can find an official logo in here: https://about.gitlab.com/images/press/logo/png/gitlab-icon-rgb.png

@tongpu
Copy link
Contributor Author

tongpu commented May 23, 2020

I was thinking to use the CI/CD logo to differentiate it from the logo used for GitLab the git service, but I'm going to replace it with the logo only version.

@mingrammer
Copy link
Owner

mingrammer commented May 23, 2020

@tongpu Oh, that makes sense. I'd accept it.

@mingrammer mingrammer added area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request labels May 23, 2020
@mingrammer
Copy link
Owner

mingrammer commented May 23, 2020

You don't need to replace it with logo only image. I'll merge it as is.

Copy link
Owner

@mingrammer mingrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mingrammer mingrammer merged commit f371b96 into mingrammer:master May 23, 2020
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...

Signed-off-by: Nicolas Lamirault <[email protected]>
nlamirault added a commit to nlamirault/diagrams that referenced this pull request Jun 4, 2020
* master: (23 commits)
  Added generic itens and blank cluster (mingrammer#171)
  bump: up to version 0.13.1
  fix: add missing firebase base class
  docs: fix i18n
  docs(web): add sponsoring
  docs: fix Saas to SaaS
  docs: add more badges
  docs: add a sponsorship link :)
  docs: add firebase, elastic, and saas categories
  bump: up to version 0.13.0
  AWS: Added more DynamoDB and IAM resources (mingrammer#180)
  Add elastic stack (mingrammer#134) (mingrammer#174)
  Add Rust programming language (mingrammer#179)
  Add flux and flagger (mingrammer#147)
  Add Saas v2 (mingrammer#89) (mingrammer#173)
  Add nodes for Firebase (mingrammer#167)
  Add ZuulCI as onprem CI resource (mingrammer#145)
  bump: up to version 0.12.0
  Add GitlabCI to onprem.ci section (mingrammer#166)
  Add Sentry to onperm.monitoring (mingrammer#165)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/onprem On-Premise provider comp/node Issue of node component kind/feat/icon Icon request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants