Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use image/bmp #48

Closed
wtn opened this issue Jan 5, 2022 · 3 comments
Closed

use image/bmp #48

wtn opened this issue Jan 5, 2022 · 3 comments

Comments

@wtn
Copy link

wtn commented Jan 5, 2022

This gem prefers image/x-bmp (reference) but image/bmp should be used instead.

image/bmp is documented here: https://www.iana.org/assignments/media-types/image/bmp
@wtn wtn mentioned this issue Jan 5, 2022
Closed
@wtn
Copy link
Author

wtn commented Jan 5, 2022

Closing at the issue appears to be in Rails, not this gem.

@wtn wtn closed this as completed Jan 5, 2022
@halostatue halostatue reopened this Jan 6, 2022
@halostatue
Copy link
Member

I believe that this is a correct change. It appears that at one point image/bmp was not registered and we never updated it when it did become registered.

@halostatue
Copy link
Member

I have released 3.2022.0105 with this fix.

@halostatue halostatue mentioned this issue Jan 6, 2022
Closed
@tagliala tagliala mentioned this issue Apr 17, 2022
Merged
ghiculescu added a commit to ghiculescu/rails that referenced this issue Apr 18, 2022
@ghiculescu
Treat image/bmp as a valid content type
a22bb8f 
This is a follow up to rails#42227 (comment)

The mime types database was incorrect regarding `image/bmp`. It has been fixed in mime-types/mime-types-data#48 and in discourse/mini_mime#45

Since a new version of `mini_mime` hasn't been cut yet, some of the tests in this PR look a bit off. But the core issue of not warning users if they use `image/bmp` is resolved.
This was referenced Apr 18, 2022
Merged
Merged
jyoun-godaddy pushed a commit to jyoun-godaddy/activestorage that referenced this issue Jul 5, 2022
@ghiculescu
Treat image/bmp as a valid content type
9a9f7df 
This is a follow up to rails/rails#42227 (comment)

The mime types database was incorrect regarding `image/bmp`. It has been fixed in mime-types/mime-types-data#48 and in discourse/mini_mime#45

Since a new version of `mini_mime` hasn't been cut yet, some of the tests in this PR look a bit off. But the core issue of not warning users if they use `image/bmp` is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@halostatue @wtn