DB updates 2022-01-06T11:58:07Z #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
CvX
approved these changes
Jan 6, 2022
ghiculescu
added a commit
to ghiculescu/rails
that referenced
this pull request
Apr 18, 2022
This is a follow up to rails#42227 (comment) The mime types database was incorrect regarding `image/bmp`. It has been fixed in mime-types/mime-types-data#48 and in discourse/mini_mime#45 Since a new version of `mini_mime` hasn't been cut yet, some of the tests in this PR look a bit off. But the core issue of not warning users if they use `image/bmp` is resolved.
|
rails/rails#44916 will fix the warning in Rails that triggered mime-types/mime-types-data#48 which in turn triggered this update. To bring this full circle, it would be awesome if a new version of this gem could be released that includes the fix in this PR. |
jyoun-godaddy
pushed a commit
to jyoun-godaddy/activestorage
that referenced
this pull request
Jul 5, 2022
This is a follow up to rails/rails#42227 (comment) The mime types database was incorrect regarding `image/bmp`. It has been fixed in mime-types/mime-types-data#48 and in discourse/mini_mime#45 Since a new version of `mini_mime` hasn't been cut yet, some of the tests in this PR look a bit off. But the core issue of not warning users if they use `image/bmp` is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Github Actions