Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable installation of milvus-lite on windows platform (#2131) #2134

Merged

Conversation

Raysilience
Copy link
Contributor

@XuanYang-cn
Since the project is managed by setuptools, and according to the setuptools, we can disable the automatic installation of milvus-lite on windows platform by adding environment markers.
Following PEP508, I pick the environment marker "sys_platform != 'win32'" to prevent the installation.
I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone.
Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging.

@sre-ci-robot
Copy link

Welcome @Raysilience! It looks like this is your first PR to milvus-io/pymilvus 🎉

@mergify mergify bot added the dco-passed label Jun 16, 2024
@XuanYang-cn XuanYang-cn self-assigned this Jun 16, 2024
@mergify mergify bot added the ci-passed label Jun 16, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Jun 17, 2024
@XuanYang-cn
Copy link
Contributor

https://github.com/milvus-io/pymilvus/actions/runs/9545655624/job/26306874213?pr=2136

@Raysilience I tested it on windows platform by github actions, and it works perfectly. THX for the contribution!

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raysilience, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 21844e9 into milvus-io:master Jun 17, 2024
9 checks passed
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
…-io#2131) (milvus-io#2134)

Since the project is managed by setuptools, and according to the
[setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html),
we can disable the automatic installation of milvus-lite on windows
platform by adding environment markers.
Following [PEP508](https://peps.python.org/pep-0508/), I pick the
environment marker "sys_platform != 'win32'" to prevent the
installation.
I build packages after the modification. Then test the .tar.gz and the
.whl files both on my windows laptop and a linux docker. The issue
mentioned in milvus-io#2131 seems gone.
Due the lack of macOS machine, I could not perform testing on that
particular platform. Please check validity before merging.

Signed-off-by: rui zhang <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Jun 17, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Jun 17, 2024
Since the project is managed by setuptools, and according to the
[setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html),
we can disable the automatic installation of milvus-lite on windows
platform by adding environment markers.
Following [PEP508](https://peps.python.org/pep-0508/), I pick the
environment marker "sys_platform != 'win32'" to prevent the
installation.
I build packages after the modification. Then test the .tar.gz and the
.whl files both on my windows laptop and a linux docker. The issue
mentioned in milvus-io#2131 seems gone.
Due the lack of macOS machine, I could not perform testing on that
particular platform. Please check validity before merging.

enhance: Check PyMilvus on Windows platform

See also: milvus-io#2131, milvus-io#2134, milvus-io#2131

Co-Authored-by: rui zhang <[email protected]>
Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants