-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: disable installation of milvus-lite on windows platform (#2131) #2134
feat: disable installation of milvus-lite on windows platform (#2131) #2134
Conversation
…-io#2131) Signed-off-by: rui zhang <[email protected]>
Welcome @Raysilience! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
https://github.com/milvus-io/pymilvus/actions/runs/9545655624/job/26306874213?pr=2136 @Raysilience I tested it on windows platform by github actions, and it works perfectly. THX for the contribution! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Raysilience, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
…-io#2131) (milvus-io#2134) Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in milvus-io#2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
See also: milvus-io#2134 Signed-off-by: yangxuan <[email protected]>
Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in milvus-io#2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. enhance: Check PyMilvus on Windows platform See also: milvus-io#2131, milvus-io#2134, milvus-io#2131 Co-Authored-by: rui zhang <[email protected]> Signed-off-by: yangxuan <[email protected]>
See also: #2134 Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Since the project is managed by setuptools, and according to the setuptools, we can disable the automatic installation of milvus-lite on windows platform by adding environment markers.
Following PEP508, I pick the environment marker "sys_platform != 'win32'" to prevent the installation.
I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone.
Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging.