[Bug]: Can not use poetry to install pymilvus >= 2.4 #2131
Comments
|
/assign @junjiejiangjjj /unassign |
|
@yanliang567: GitHub didn't allow me to assign the following users: junjiejiangjjj. Note that only milvus-io members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Raysilience pymilvus 2.3.4 includes a milvus-lite lib, and it is not supported in windows. |
|
@zhuwenxing Mine is windows. Then how to exclude the milvus-lite while installing pymilvus. |
@XuanYang-cn @junjiejiangjjj |
|
@zhuwenxing @XuanYang-cn @junjiejiangjjj I check the pyproject.toml file. Maintainers list the milvus-lite inside the dependencies that leads to mandatory installation. This will definitely affect the developers operating on windows who are also using poetry to manage their projects. Would you consider moving the milvus-lite to optional dependencies such that windows developers still have access to pymilvus while other users are still able to install milvus-lite via poetry add pymilvus[milvus-lite] i.e. |
|
@Raysilience we want "milvus-lite" to be the default dependency of pymilvus. So "No" for change it to optional dependencies for all platform. However making it optional for Windows platform ONLY might be possible. Can you investigate and create a pr for it? I'll do some investigation myself too. |
XuanYang-cn
added
kind/feature
milvus-lite
|
@XuanYang-cn Sure, I find out that poetry supports environment marker which might be suitable for the current case. I will give it a try, and if it works I will create a pr |
…-io#2131) Signed-off-by: rui zhang <[email protected]>
…#2134) @XuanYang-cn Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
|
#2136 This PR will add checks for windows platform for every PR. |
…-io#2131) (milvus-io#2134) Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in milvus-io#2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. Signed-off-by: rui zhang <[email protected]>
Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in milvus-io#2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. enhance: Check PyMilvus on Windows platform See also: milvus-io#2131, milvus-io#2134, milvus-io#2131 Co-Authored-by: rui zhang <[email protected]> Signed-off-by: yangxuan <[email protected]>
Since the project is managed by setuptools, and according to the [setuptools](https://setuptools.pypa.io/en/latest/userguide/dependency_management.html), we can disable the automatic installation of milvus-lite on windows platform by adding environment markers. Following [PEP508](https://peps.python.org/pep-0508/), I pick the environment marker "sys_platform != 'win32'" to prevent the installation. I build packages after the modification. Then test the .tar.gz and the .whl files both on my windows laptop and a linux docker. The issue mentioned in #2131 seems gone. Due the lack of macOS machine, I could not perform testing on that particular platform. Please check validity before merging. enhance: Check PyMilvus on Windows platform --------- Signed-off-by: yangxuan <[email protected]> Co-authored-by: Rui Zhang <[email protected]> Co-authored-by: rui zhang <[email protected]>
|
Should be ready in pymilvus==2.4.4 |
Is there an existing issue for this?
Describe the bug
create a new environment using poetry, execute in terminal
poetry add pymilvus=^2.4.3, it will raise the following error,Expected Behavior
successfully install pymilvus with poetry
Steps/Code To Reproduce behavior
Environment details
Anything else?
No response
The text was updated successfully, but these errors were encountered: