Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of insert by rows #1434

Merged
merged 1 commit into from
May 25, 2023
Merged

Add support of insert by rows #1434

merged 1 commit into from
May 25, 2023

Conversation

czs007
Copy link
Contributor

@czs007 czs007 commented May 16, 2023 •
edited
Loading

issue #1454

@mergify mergify bot added the dco-passed label May 16, 2023
@czs007 czs007 changed the title Example of insert rows Add support of insert by rows May 22, 2023
@czs007 czs007 force-pushed the insert_rows branch 4 times, most recently from de978e0 to d1bcadd Compare May 24, 2023 03:24
@czs007
Copy link
Contributor Author

czs007 commented May 24, 2023

/unhold

@mergify mergify bot added the ci-passed label May 24, 2023
filip-halt
filip-halt reviewed May 25, 2023
View reviewed changes
examples/dynamic_field.py Show resolved Hide resolved
pymilvus/orm/collection.py Show resolved Hide resolved
@longjiquan
Copy link
Contributor

/lgtm
/approve

@czs007
Copy link
Contributor Author

czs007 commented May 25, 2023

/hold

@czs007
Add support of insert by rows
37f0da7 
Signed-off-by: zhenshan.cao <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label May 25, 2023
@czs007
Copy link
Contributor Author

czs007 commented May 25, 2023

/unhold

@longjiquan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 72761ed into milvus-io:master May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filip-halt filip-halt filip-halt left review comments

@longjiquan longjiquan Awaiting requested review from longjiquan

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Assignees

@longjiquan longjiquan

Labels
approved ci-passed dco-passed lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@czs007 @longjiquan @sre-ci-robot @filip-halt