Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix incorrect memory estimation for small segments #38910

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Skip estimation index memory logic for segments without index file.

issue: #37630

pr: #38813

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 1, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.40%. Comparing base (ccbe6fc) to head (8b0795a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38910      +/-   ##
==========================================
+ Coverage   80.48%   83.40%   +2.92%     
==========================================
  Files        1077      809     -268     
  Lines      169574   143079   -26495     
==========================================
- Hits       136483   119341   -17142     
+ Misses      28646    19267    -9379     
- Partials     4445     4471      +26     
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment_loader.go 71.41% <100.00%> (-0.23%) ⬇️

... and 306 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants