Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect memory estimation for small segments #38813

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

Skip estimation index memory logic for segments without index file.

issue: #37630

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 27, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 27, 2024
czs007 pushed a commit that referenced this pull request Dec 27, 2024
Skip estimation index memory logic for segments without index file.

issue: #37630

pr: #38813

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Dec 27, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (95c1ccc) to head (6a27227).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38813       +/-   ##
===========================================
+ Coverage   69.45%   82.93%   +13.48%     
===========================================
  Files         294     1091      +797     
  Lines       26430   169629   +143199     
===========================================
+ Hits        18357   140685   +122328     
- Misses       8073    23346    +15273     
- Partials        0     5598     +5598     
Components Coverage Δ
Client 79.12% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.08% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment_loader.go 72.54% <100.00%> (ø)

... and 1384 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

rerun cpp-unit-test

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Dec 30, 2024
@mergify mergify bot added the ci-passed label Dec 30, 2024
@mergify mergify bot removed the ci-passed label Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants