-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix incorrect memory estimation for small segments #38813
base: master
Are you sure you want to change the base?
fix: Fix incorrect memory estimation for small segments #38813
Conversation
Signed-off-by: bigsheeper <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Skip estimation index memory logic for segments without index file. issue: #37630 pr: #38813 Signed-off-by: bigsheeper <[email protected]>
@bigsheeper cpp-unit-test check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38813 +/- ##
===========================================
+ Coverage 69.45% 82.93% +13.48%
===========================================
Files 294 1091 +797
Lines 26430 169629 +143199
===========================================
+ Hits 18357 140685 +122328
- Misses 8073 23346 +15273
- Partials 0 5598 +5598
|
rerun cpp-unit-test |
…2-fix-wrong-mem-estimate
@bigsheeper go-sdk check failed, comment |
rerun go-sdk |
@bigsheeper go-sdk check failed, comment |
rerun go-sdk |
@bigsheeper go-sdk check failed, comment |
rerun go-sdk |
@bigsheeper go-sdk check failed, comment |
Skip estimation index memory logic for segments without index file.
issue: #37630