Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix incorrect memory estimation for small segments #38813

Merged
merged 3 commits into from
Jan 13, 2025

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…

285bd54
Select commit
Loading
Failed to load commit list.
Merged

fix: Fix incorrect memory estimation for small segments #38813

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
285bd54
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 13, 2025 in 0s

82.96% (target 77.00%)

View this Pull Request on Codecov

82.96% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.96%. Comparing base (aceb972) to head (285bd54).
Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38813      +/-   ##
==========================================
+ Coverage   81.18%   82.96%   +1.78%     
==========================================
  Files        1390     1094     -296     
  Lines      196755   170148   -26607     
==========================================
- Hits       159732   141161   -18571     
+ Misses      31442    23395    -8047     
- Partials     5581     5592      +11     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.10% <100.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment_loader.go 72.79% <100.00%> (-0.25%) ⬇️

... and 332 files with indirect coverage changes