enhance: remove the rpc layer of coordinator when enabling standalone or mixcoord #37815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
1 task
|
@chyezh E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37815 +/- ##
========================================
Coverage 81.02% 81.03%
========================================
Files 1357 1360 +3
Lines 190195 190664 +469
========================================
+ Hits 154113 154501 +388
- Misses 30601 30671 +70
- Partials 5481 5492 +11
|
chyezh
changed the title
chyezh
force-pushed
the
enhance_merge_all_coord_into_one
branch
2 times, most recently
from
d10f396 to
cec8f21
Compare
|
@chyezh go-sdk check failed, comment |
chyezh
force-pushed
the
enhance_merge_all_coord_into_one
branch
2 times, most recently
from
a7daaae to
7cb3836
Compare
|
@chyezh E2e jenkins job failed, comment |
chyezh
force-pushed
the
enhance_merge_all_coord_into_one
branch
2 times, most recently
from
b13e4d3 to
44831eb
Compare
sre-ci-robot
added
area/dependency
… or mixcoord Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
enhance_merge_all_coord_into_one
branch
from
44831eb to
e495cbf
Compare
|
@chyezh go-sdk check failed, comment |
|
rerun go-sdk |
Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
enhance_merge_all_coord_into_one
branch
from
4584c90 to
d9b81d4
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Nov 25, 2024
… or mixcoord (#37959) issue: #37764 pr: #37815 - add a local client to call local server directly for querycoord/rootcoord/datacoord. - enable local client if milvus is running mixcoord or standalone mode. --------- Signed-off-by: chyezh <[email protected]>
JsDove
pushed a commit
to JsDove/milvus
that referenced
this pull request
Nov 26, 2024
… or mixcoord (milvus-io#37815) issue: milvus-io#37764 - add a local client to call local server directly for querycoord/rootcoord/datacoord. - enable local client if milvus is running mixcoord or standalone mode. --------- Signed-off-by: chyezh <[email protected]>
This was referenced Dec 4, 2024
czs007
pushed a commit
that referenced
this pull request
Dec 5, 2024
… or mixcoord (#38246) issue: #33285 pr: #37815 - remove the rpc layer of coordinator when enabling standalone or mixcoord - move health check into init --------- Signed-off-by: chyezh <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Dec 10, 2024
… or mixcoord (#38207) issue: #37764 pr: #37815 also see: #38259 - add a local client to call local server directly for querycoord/rootcoord/datacoord. - enable local client if milvus is running mixcoord or standalone mode. - after removing rpc layer from mixcoord, the querycoord at standby mode will be blocked forever of deployment rolling --------- Signed-off-by: chyezh <[email protected]>
This was referenced Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #37764