-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
enhance: remove the rpc layer of coordinator when enabling standalone…
… or mixcoord (#38246) issue: #33285 pr: #37815 - remove the rpc layer of coordinator when enabling standalone or mixcoord - move health check into init --------- Signed-off-by: chyezh <[email protected]>
- Loading branch information
Showing
13 changed files
with
187 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| package grpcclient | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "reflect" | ||
| "strings" | ||
|
|
||
| "google.golang.org/grpc" | ||
| "google.golang.org/grpc/codes" | ||
| "google.golang.org/grpc/status" | ||
| ) | ||
|
|
||
| var _ grpc.ClientConnInterface = &localConn{} | ||
|
|
||
| // NewLocalGRPCClient creates a grpc client that calls the server directly. | ||
| // !!! Warning: it didn't make any network or serialization/deserialization, so it's not promise concurrent safe. | ||
| // and there's no interceptor for client and server like the common grpc client/server. | ||
| func NewLocalGRPCClient[C any, S any](desc *grpc.ServiceDesc, server S, clientCreator func(grpc.ClientConnInterface) C) C { | ||
| return clientCreator(&localConn{ | ||
| serviceDesc: desc, | ||
| server: server, | ||
| }) | ||
| } | ||
|
|
||
| // localConn is a grpc.ClientConnInterface implementation that calls the server directly. | ||
| type localConn struct { | ||
| serviceDesc *grpc.ServiceDesc // ServiceDesc is the descriptor for this service. | ||
| server interface{} // the server object. | ||
| } | ||
|
|
||
| // Invoke calls the server method directly. | ||
| func (c *localConn) Invoke(ctx context.Context, method string, args, reply interface{}, opts ...grpc.CallOption) error { | ||
| methodDesc := c.findMethod(method) | ||
| if methodDesc == nil { | ||
| return status.Errorf(codes.Unimplemented, fmt.Sprintf("method %s not implemented", method)) | ||
| } | ||
| resp, err := methodDesc.Handler(c.server, ctx, func(in any) error { | ||
| reflect.ValueOf(in).Elem().Set(reflect.ValueOf(args).Elem()) | ||
| return nil | ||
| }, nil) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| reflect.ValueOf(reply).Elem().Set(reflect.ValueOf(resp).Elem()) | ||
| return nil | ||
| } | ||
|
|
||
| // NewStream is not supported by now, wait for implementation. | ||
| func (c *localConn) NewStream(ctx context.Context, desc *grpc.StreamDesc, method string, opts ...grpc.CallOption) (grpc.ClientStream, error) { | ||
| panic("we don't support local stream rpc by now") | ||
| } | ||
|
|
||
| // findMethod finds the method descriptor by the full method name. | ||
| func (c *localConn) findMethod(fullMethodName string) *grpc.MethodDesc { | ||
| strs := strings.SplitN(fullMethodName[1:], "/", 2) | ||
| serviceName := strs[0] | ||
| methodName := strs[1] | ||
| if c.serviceDesc.ServiceName != serviceName { | ||
| return nil | ||
| } | ||
| for i := range c.serviceDesc.Methods { | ||
| if c.serviceDesc.Methods[i].MethodName == methodName { | ||
| return &c.serviceDesc.Methods[i] | ||
| } | ||
| } | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package grpcclient | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
|
|
||
| "github.com/milvus-io/milvus/internal/proto/rootcoordpb" | ||
| ) | ||
|
|
||
| type mockRootCoordServer struct { | ||
| t *testing.T | ||
| *rootcoordpb.UnimplementedRootCoordServer | ||
| } | ||
|
|
||
| func (s *mockRootCoordServer) AllocID(ctx context.Context, req *rootcoordpb.AllocIDRequest) (*rootcoordpb.AllocIDResponse, error) { | ||
| assert.NotNil(s.t, req) | ||
| assert.Equal(s.t, uint32(100), req.Count) | ||
| return &rootcoordpb.AllocIDResponse{ | ||
| ID: 1, | ||
| Count: 2, | ||
| }, nil | ||
| } | ||
|
|
||
| func TestLocalGRPCClient(t *testing.T) { | ||
| localClient := NewLocalGRPCClient( | ||
| &rootcoordpb.RootCoord_ServiceDesc, | ||
| &mockRootCoordServer{ | ||
| t: t, | ||
| UnimplementedRootCoordServer: &rootcoordpb.UnimplementedRootCoordServer{}, | ||
| }, | ||
| rootcoordpb.NewRootCoordClient, | ||
| ) | ||
| result, err := localClient.AllocTimestamp(context.Background(), &rootcoordpb.AllocTimestampRequest{}) | ||
| assert.Error(t, err) | ||
| assert.Nil(t, result) | ||
|
|
||
| result2, err := localClient.AllocID(context.Background(), &rootcoordpb.AllocIDRequest{ | ||
| Count: 100, | ||
| }) | ||
| assert.NoError(t, err) | ||
| assert.NotNil(t, result2) | ||
| assert.Equal(t, int64(1), result2.ID) | ||
| assert.Equal(t, uint32(2), result2.Count) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.