enhance: Decouple shard client manager from shard cache (#37371) #37753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) issue: milvus-io#37115 the old implementation update shard cache and shard client manager at same time, which causes lots of conor case due to concurrent issue without lock. This PR decouple shard client manager from shard cache, so only shard cache will be updated if delegator changes. and make sure shard client manager will always return the right client, and create a new client if not exist. in case of client leak, shard client manager will purge client in async for every 10 minutes. --------- Signed-off-by: Wei Liu <[email protected]>
mergify
bot
added
dco-passed
…s-io#37646) Related to previous pr: milvus-io#37371 Signed-off-by: Congqi Xia <[email protected]> Signed-off-by: Wei Liu <[email protected]>
This PR refine the shard client ref counter, dec ref counter won't release client anymore, and only permit shard client manager to remove client. Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #37753 +/- ##
==========================================
+ Coverage 72.28% 79.65% +7.36%
==========================================
Files 1069 1069
Lines 166874 166869 -5
==========================================
+ Hits 120619 132912 +12293
+ Misses 41853 29544 -12309
- Partials 4402 4413 +11
|
Signed-off-by: Wei Liu <[email protected]>
|
rerun ut |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, weiliu1031 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yanliang567
added
ci-passed
manual-pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #37115
pr: #37371 #37646 #37729
the old implementation update shard cache and shard client manager at same time, which causes lots of conor case due to concurrent issue without lock.
This PR decouple shard client manager from shard cache, so only shard cache will be updated if delegator changes. and make sure shard client manager will always return the right client, and create a new client if not exist. in case of client leak, shard client manager will purge client in async for every 10 minutes.