Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Fix lb policy retry log after targetNode type changed #37646

Merged
merged 1 commit into from
Nov 13, 2024
Merged

enhance: Fix lb policy retry log after targetNode type changed #37646

merged 1 commit into from
Nov 13, 2024

Conversation

congqixia
Copy link
Contributor

Related to previous pr: #37371

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 13, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun go-sdk

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.56%. Comparing base (cf883b1) to head (ab174b0).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37646       +/-   ##
===========================================
+ Coverage   68.07%   80.56%   +12.49%     
===========================================
  Files         290     1357     +1067     
  Lines       25455   190431   +164976     
===========================================
+ Hits        17328   153430   +136102     
- Misses       8127    31589    +23462     
- Partials        0     5412     +5412
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.07% <ø> (ø)
Go 83.20% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/proxy/lb_policy.go 98.06% <100.00%> (ø)

... and 1066 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Nov 13, 2024
@sre-ci-robot sre-ci-robot merged commit e7fb87d into milvus-io:master Nov 13, 2024
20 checks passed
@congqixia congqixia deleted the enhance/fix_lbpolicy_retrylog branch November 14, 2024 07:20
@weiliu1031 weiliu1031 mentioned this pull request Nov 17, 2024
Merged
weiliu1031 pushed a commit to weiliu1031/milvus that referenced this pull request Nov 17, 2024
@congqixia @weiliu1031
enhance: Fix lb policy retry log after targetNode type changed (milvu…
e279861 
…s-io#37646)

Related to previous pr: milvus-io#37371

Signed-off-by: Congqi Xia <[email protected]>
Signed-off-by: Wei Liu <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 25, 2024
@weiliu1031 @congqixia
enhance: Decouple shard client manager from shard cache (#37371) (#37753
b245101 
)

issue: #37115
pr: #37371 #37646 #37729
the old implementation update shard cache and shard client manager at
same time, which causes lots of conor case due to concurrent issue
without lock.

This PR decouple shard client manager from shard cache, so only shard
cache will be updated if delegator changes. and make sure shard client
manager will always return the right client, and create a new client if
not exist. in case of client leak, shard client manager will purge
client in async for every 10 minutes.

---------

---------

Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Congqi Xia <[email protected]>
Co-authored-by: congqixia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congqixia @sre-ci-robot @weiliu1031