Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [CP25] remove useless vector index param checker #37330

Merged

remove useless vector index param checker

29196cc
Select commit
Loading
Failed to load commit list.
Merged

enhance: [CP25] remove useless vector index param checker #37330

remove useless vector index param checker
29196cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 4, 2024 in 0s

80.96% (target 77.00%)

View this Pull Request on Codecov

80.96% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (12fb9d6) to head (29196cc).
Report is 16 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37330      +/-   ##
==========================================
- Coverage   83.15%   80.96%   -2.20%     
==========================================
  Files        1029     1302     +273     
  Lines      157316   182375   +25059     
==========================================
+ Hits       130822   147653   +16831     
- Misses      21327    29542    +8215     
- Partials     5167     5180      +13     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.93% <ø> (∅)
Go 83.25% <100.00%> (+0.07%) ⬆️
Files with missing lines Coverage Δ
internal/util/indexparamcheck/base_checker.go 88.88% <ø> (+11.11%) ⬆️
...ernal/util/indexparamcheck/vector_index_checker.go 86.95% <100.00%> (+0.80%) ⬆️
pkg/util/typeutil/schema.go 85.14% <100.00%> (+0.02%) ⬆️

... and 322 files with indirect coverage changes