Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [CP25] remove useless vector index param checker #37330

Merged
merged 1 commit into from
Nov 4, 2024
Merged

enhance: [CP25] remove useless vector index param checker #37330

merged 1 commit into from
Nov 4, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Oct 31, 2024

issue: #34298
pr: #37329

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (12fb9d6) to head (29196cc).
Report is 17 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37330      +/-   ##
==========================================
- Coverage   83.15%   80.96%   -2.20%     
==========================================
  Files        1029     1302     +273     
  Lines      157316   182375   +25059     
==========================================
+ Hits       130822   147653   +16831     
- Misses      21327    29542    +8215     
- Partials     5167     5180      +13
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.93% <ø> (∅)
Go 83.25% <100.00%> (+0.07%) ⬆️
Files with missing lines Coverage Δ
internal/util/indexparamcheck/base_checker.go 88.88% <ø> (+11.11%) ⬆️
...ernal/util/indexparamcheck/vector_index_checker.go 86.95% <100.00%> (+0.80%) ⬆️
pkg/util/typeutil/schema.go 85.14% <100.00%> (+0.02%) ⬆️

... and 322 files with indirect coverage changes

@foxspy foxspy force-pushed the remove_useless_vector_checker_25 branch from 5f93320 to 29196cc Compare October 31, 2024 07:01
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 31, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Oct 31, 2024

/run-cpu-e2e

1 similar comment
@foxspy
Copy link
Contributor Author

foxspy commented Oct 31, 2024

/run-cpu-e2e

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

1 similar comment
@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

2 similar comments
@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

@yellow-shine
Copy link
Collaborator

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

3 similar comments
@foxspy
Copy link
Contributor Author

foxspy commented Nov 3, 2024

/run-cpu-e2e

@foxspy
Copy link
Contributor Author

foxspy commented Nov 3, 2024

/run-cpu-e2e

@foxspy
Copy link
Contributor Author

foxspy commented Nov 4, 2024

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 4, 2024
@sre-ci-robot sre-ci-robot merged commit 8ba0a4a into milvus-io:2.5 Nov 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foxspy @xiaofan-luan @sre-ci-robot @yellow-shine @czs007