enhance: [CP25] remove useless vector index param checker (#37330)

issue: #34298 pr: #37329 Signed-off-by: xianliang.li <[email protected]>
milvus-io · Nov 4, 2024 · 8ba0a4a · 8ba0a4a
1 parent 309c0b1
commit 8ba0a4a
Show file tree

Hide file tree

Showing 22 changed files with 14 additions and 691 deletions.
diff --git a/internal/util/indexparamcheck/base_checker.go b/internal/util/indexparamcheck/base_checker.go
@@ -17,28 +17,14 @@
 package indexparamcheck
 
 import (
-	"fmt"
-	"math"
-
 	"github.com/cockroachdb/errors"
 
 	"github.com/milvus-io/milvus-proto/go-api/v2/schemapb"
-	"github.com/milvus-io/milvus/pkg/util/typeutil"
 )
 
 type baseChecker struct{}
 
 func (c baseChecker) CheckTrain(dataType schemapb.DataType, params map[string]string) error {
-	if typeutil.IsSparseFloatVectorType(dataType) {
-		if !CheckStrByValues(params, Metric, SparseMetrics) {
-			return fmt.Errorf("metric type not found or not supported for sparse float vectors, supported: %v", SparseMetrics)
-		}
-	} else {
-		// we do not check dim for sparse
-		if !CheckIntByRange(params, DIM, 1, math.MaxInt) {
-			return fmt.Errorf("failed to check vector dimension, should be larger than 0 and smaller than math.MaxInt")
-		}
-	}
 	return nil
 }
 

diff --git a/internal/util/indexparamcheck/bin_flat_checker.go b/internal/util/indexparamcheck/bin_flat_checker.go
diff --git a/internal/util/indexparamcheck/bin_ivf_flat_checker.go b/internal/util/indexparamcheck/bin_ivf_flat_checker.go
diff --git a/internal/util/indexparamcheck/binary_vector_base_checker.go b/internal/util/indexparamcheck/binary_vector_base_checker.go
diff --git a/internal/util/indexparamcheck/cagra_checker.go b/internal/util/indexparamcheck/cagra_checker.go
diff --git a/internal/util/indexparamcheck/diskann_checker.go b/internal/util/indexparamcheck/diskann_checker.go
diff --git a/internal/util/indexparamcheck/flat_checker.go b/internal/util/indexparamcheck/flat_checker.go
diff --git a/internal/util/indexparamcheck/float_vector_base_checker.go b/internal/util/indexparamcheck/float_vector_base_checker.go
diff --git a/internal/util/indexparamcheck/hnsw_checker.go b/internal/util/indexparamcheck/hnsw_checker.go
diff --git a/internal/util/indexparamcheck/ivf_base_checker.go b/internal/util/indexparamcheck/ivf_base_checker.go