Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse fail in empty json(#37294) #37295

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

smellthemoon
Copy link
Contributor

pr: #37294
issue: #37200

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 30, 2024
Copy link
Contributor

mergify bot commented Oct 30, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.84%. Comparing base (6b9b699) to head (8d0d094).
Report is 3 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/common/Json.h 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #37295      +/-   ##
==========================================
- Coverage   83.10%   80.84%   -2.27%     
==========================================
  Files        1031     1321     +290     
  Lines      157671   183092   +25421     
==========================================
+ Hits       131034   148012   +16978     
- Misses      21443    29871    +8428     
- Partials     5194     5209      +15     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.92% <50.00%> (∅)
Go 83.10% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/Json.h 67.90% <50.00%> (ø)

... and 315 files with indirect coverage changes

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 30, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 30, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 30, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@smellthemoon
Copy link
Contributor Author

rerun ut

@zhagnlu
Copy link
Contributor

zhagnlu commented Nov 1, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e714e42 into milvus-io:2.5 Nov 1, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants