Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse fail in empty json #37294

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot requested a review from czs007 October 30, 2024 04:59
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 30, 2024
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (90948e9) to head (ca24bd9).
Report is 29 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/Json.h 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37294      +/-   ##
==========================================
- Coverage   83.11%   80.89%   -2.22%     
==========================================
  Files        1029     1319     +290     
  Lines      157231   182670   +25439     
==========================================
+ Hits       130689   147779   +17090     
- Misses      21379    29723    +8344     
- Partials     5163     5168       +5     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.12% <50.00%> (∅)
Go 83.15% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/common/Json.h 67.90% <50.00%> (ø)

... and 329 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 30, 2024
@xiaofan-luan
Copy link
Collaborator

@smellthemoon
need a ut test for this case?

@zhagnlu
Copy link
Contributor

zhagnlu commented Nov 1, 2024

/lgtm

sre-ci-robot pushed a commit that referenced this pull request Nov 1, 2024
pr: #37294 
issue: #37200

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Nov 3, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 51cb2fb into milvus-io:master Nov 3, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants