Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refine code for get_deleted_bitmap (#36819) #37204

Merged

Conversation

xiaocai2333
Copy link
Contributor

issue: #33744

master pr: #36819

Check whether the PK is truly sorted in the debug model.

issue: milvus-io#33744 

Check whether the PK is truly sorted in the debug model.

---------

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 28, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (cdee149) to head (86d91f4).
Report is 31 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37204       +/-   ##
===========================================
+ Coverage   66.87%   81.19%   +14.31%     
===========================================
  Files         290     1319     +1029     
  Lines       25471   183898   +158427     
===========================================
+ Hits        17035   149315   +132280     
- Misses       8436    29439    +21003     
- Partials        0     5144     +5144     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.89% <100.00%> (+0.01%) ⬆️
Go 83.51% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.cpp 83.98% <100.00%> (-0.22%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.h 37.93% <ø> (ø)
internal/core/src/segcore/Utils.h 100.00% <100.00%> (ø)

... and 1033 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Oct 28, 2024
@xiaocai2333 xiaocai2333 added this to the 2.5.0 milestone Oct 30, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 30, 2024

/approve
/lgtm

@czs007
Copy link
Collaborator

czs007 commented Oct 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9552190 into milvus-io:master Oct 30, 2024
19 checks passed
Copy link
Contributor

mergify bot commented Oct 30, 2024

⚠️ The sha of the head commit of this PR conflicts with #37297. Mergify cannot evaluate rules on this PR. ⚠️

@xiaocai2333 xiaocai2333 deleted the refine_get_delete_bitmap-5 branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants