Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Refine code for get_deleted_bitmap #36819

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #33744

Check whether the PK is truly sorted in the debug model.

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Oct 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 12, 2024
@xiaocai2333 xiaocai2333 force-pushed the refine_mark_with_delete branch from 8ee1b11 to 5764214 Compare October 14, 2024 01:57
@czs007
Copy link
Collaborator

czs007 commented Oct 17, 2024

/approve

Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 xiaocai2333 force-pushed the refine_mark_with_delete branch from 5764214 to 9e24ad3 Compare October 18, 2024 02:06
@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Oct 18, 2024
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Project coverage is 72.36%. Comparing base (277c50f) to head (9e24ad3).
Report is 91 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% 14 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36819      +/-   ##
==========================================
- Coverage   72.52%   72.36%   -0.17%     
==========================================
  Files        1308     1310       +2     
  Lines      156362   183527   +27165     
==========================================
+ Hits       113407   132808   +19401     
- Misses      37840    45599    +7759     
- Partials     5115     5120       +5     
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentSealedImpl.h 12.50% <ø> (ø)
internal/core/src/segcore/Utils.h 82.85% <100.00%> (+1.03%) ⬆️
internal/core/src/segcore/SegmentSealedImpl.cpp 0.00% <0.00%> (ø)

... and 1162 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Oct 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 86687bd into milvus-io:master Oct 28, 2024
14 of 16 checks passed
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 28, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Oct 28, 2024
sre-ci-robot pushed a commit that referenced this pull request Oct 30, 2024
issue: #33744 

master pr: #36819 

Check whether the PK is truly sorted in the debug model.

Signed-off-by: Cai Zhang <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Oct 31, 2024
issue: #33744 

master pr: #36819 

Check whether the PK is truly sorted in the debug model.

Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 xiaocai2333 deleted the refine_mark_with_delete branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants