Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add checkers for Faiss-based HNSW #36857

Merged
merged 1 commit into from
Oct 15, 2024
Merged

enhance: add checkers for Faiss-based HNSW #36857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/util/indexparamcheck/conf_adapter_mgr.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ func (mgr *indexCheckerMgrImpl) registerIndexChecker() {
mgr.checkers[IndexHNSW] = newHnswChecker()
mgr.checkers[IndexDISKANN] = newDiskannChecker()
mgr.checkers[IndexSparseInverted] = newSparseInvertedIndexChecker()
mgr.checkers[IndexFaissHNSW] = newFloatVectorBaseChecker()
mgr.checkers[IndexFaissHNSWPQ] = newFloatVectorBaseChecker()
mgr.checkers[IndexFaissHNSWSQ] = newFloatVectorBaseChecker()
mgr.checkers[IndexFaissHNSWPRQ] = newFloatVectorBaseChecker()
// WAND doesn't have more index params than sparse inverted index, thus
// using the same checker.
mgr.checkers[IndexSparseWand] = newSparseInvertedIndexChecker()
Expand Down
8 changes: 8 additions & 0 deletions pkg/util/indexparamcheck/index_type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ const (
IndexDISKANN IndexType = "DISKANN"
IndexSparseInverted IndexType = "SPARSE_INVERTED_INDEX"
IndexSparseWand IndexType = "SPARSE_WAND"
// For temporary use, will be removed in the future.
// 1. All Index related param check will be moved to Knowhere recently.
// 2. FAISS_HNSW_xxx will be rename to HNSW_xxx after QA test. We keep the original name for comparison purpose.
// TODO: @liliu-z @foxspy
IndexFaissHNSW IndexType = "FAISS_HNSW_FLAT"
IndexFaissHNSWPQ IndexType = "FAISS_HNSW_PQ"
IndexFaissHNSWSQ IndexType = "FAISS_HNSW_SQ"
IndexFaissHNSWPRQ IndexType = "FAISS_HNSW_PRQ"

// scalar index
IndexSTLSORT IndexType = "STL_SORT"
Expand Down
Loading