-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: add checkers for Faiss-based HNSW #36857
Conversation
Signed-off-by: Li Liu <[email protected]>
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, liliu-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liliu-z go-sdk check failed, comment |
@liliu-z E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36857 +/- ##
==========================================
+ Coverage 81.54% 84.61% +3.06%
==========================================
Files 1308 1024 -284
Lines 156172 130820 -25352
==========================================
- Hits 127343 110687 -16656
+ Misses 23735 15014 -8721
- Partials 5094 5119 +25
|
rerun go-sdk |
/run-cpu-e2e |
Knowhere introduced FAISS-based HNSQ Flat/SQ/PQ/PRQ. This PR adds param check in Milvus side.
This PR actually do nothing but let the check pass, since:
FAISS_HNSW_xx
toHNSW_xx
after QA test. @alexanderguzhva