Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: add checkers for Faiss-based HNSW #36857

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

liliu-z
Copy link
Member

@liliu-z liliu-z commented Oct 14, 2024

Knowhere introduced FAISS-based HNSQ Flat/SQ/PQ/PRQ. This PR adds param check in Milvus side.

This PR actually do nothing but let the check pass, since:

  1. All indexes param check will be moved to Knowhere recently. @foxspy
  2. The index name will be changed from FAISS_HNSW_xx to HNSW_xx after QA test. @alexanderguzhva

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Oct 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 14, 2024
Copy link
Contributor

mergify bot commented Oct 14, 2024

@liliu-z

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@liliu-z liliu-z changed the title Add checkers for Faiss-based HNSW enhance: Add checkers for Faiss-based HNSW Oct 14, 2024
@liliu-z liliu-z changed the title enhance: Add checkers for Faiss-based HNSW enhance: add checkers for Faiss-based HNSW Oct 14, 2024
@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Oct 14, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 14, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Oct 14, 2024

@liliu-z go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 14, 2024

@liliu-z E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.61%. Comparing base (f46c3ac) to head (48a8b16).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36857      +/-   ##
==========================================
+ Coverage   81.54%   84.61%   +3.06%     
==========================================
  Files        1308     1024     -284     
  Lines      156172   130820   -25352     
==========================================
- Hits       127343   110687   -16656     
+ Misses      23735    15014    -8721     
- Partials     5094     5119      +25     
Files with missing lines Coverage Δ
pkg/util/indexparamcheck/conf_adapter_mgr.go 100.00% <100.00%> (ø)
pkg/util/indexparamcheck/index_type.go 83.33% <ø> (ø)

... and 321 files with indirect coverage changes

@liliu-z
Copy link
Member Author

liliu-z commented Oct 15, 2024

rerun go-sdk

@liliu-z
Copy link
Member Author

liliu-z commented Oct 15, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 15, 2024
@sre-ci-robot sre-ci-robot merged commit b0d5866 into milvus-io:master Oct 15, 2024
16 checks passed
@liliu-z liliu-z deleted the add_faiss_hnsw_checker branch October 15, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants