enhance: [cherry-pick]Convert unincode to ascii to improving expression parsing efficiency #36676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cai Zhang <[email protected]>
mergify
bot
added
dco-passed
xiaocai2333
commented
Oct 8, 2024
| @@ -553,6 +557,67 @@ func (v *ParserVisitor) VisitTerm(ctx *parser.TermContext) interface{} { | |||
| } | |||
| } | |||
|
|
|||
| //// VisitTerm translates expr to term plan. | |||
| // VisitString translates expr to GenericValue. | ||
| func (v *ParserVisitor) VisitString(ctx *parser.StringContext) interface{} { | ||
| pattern, err := convertEscapeSingle(ctx.StringLiteral().GetText()) | ||
| func parseString(text string) interface{} { |
Signed-off-by: Cai Zhang <[email protected]>
sre-ci-robot
added
size/M
|
@xiaocai2333 E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #36676 +/- ##
===========================================
+ Coverage 70.14% 81.22% +11.07%
===========================================
Files 1064 1064
Lines 140471 140498 +27
===========================================
+ Hits 98533 114118 +15585
+ Misses 37598 22055 -15543
+ Partials 4340 4325 -15
|
|
/lgtm |
Signed-off-by: Cai Zhang <[email protected]>
sre-ci-robot
added
size/L
Signed-off-by: Cai Zhang <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaocai2333, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36672
master pr: #36675