Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Convert unincode to ascii to improving expression parsing efficiency #36675

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 8, 2024
Copy link
Contributor

mergify bot commented Oct 8, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (1f47d55) to head (67281c9).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36675      +/-   ##
==========================================
- Coverage   73.29%   73.26%   -0.04%     
==========================================
  Files        1286     1286              
  Lines      152093   152070      -23     
==========================================
- Hits       111484   111417      -67     
- Misses      35575    35609      +34     
- Partials     5034     5044      +10     
Files with missing lines Coverage Δ
internal/parser/planparserv2/parser_visitor.go 89.34% <100.00%> (ø)
internal/parser/planparserv2/plan_parser_v2.go 89.09% <100.00%> (+1.67%) ⬆️
internal/parser/planparserv2/utils.go 92.60% <100.00%> (+0.31%) ⬆️

... and 41 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 8, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

Signed-off-by: Cai Zhang <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Oct 8, 2024
@mergify mergify bot added the ci-passed label Oct 8, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaocai2333, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fc8b5ab into milvus-io:master Oct 9, 2024
14 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Oct 9, 2024
…on parsing efficiency (#36676)

issue: #36672 

master pr: #36675

---------

Signed-off-by: Cai Zhang <[email protected]>
@xiaocai2333 xiaocai2333 deleted the convert_unicode_to_ascii branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants