Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add L0 forward policy to support remote load (#36189) #36208

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #36189
Related to #35303

This PR add a param item to support change l0 forward behavior from bf filtering and forward to remote load.


Related to milvus-io#35303

This PR add a param item to support change l0 forward behavior from bf
filtering and forward to remote load.

---------

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added approved size/L Denotes a PR that changes 100-499 lines. labels Sep 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Sep 12, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 48.05195% with 40 lines in your changes missing coverage. Please review.

Project coverage is 81.16%. Comparing base (089790a) to head (38d8258).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
...l/querynodev2/delegator/delegator_delta_forward.go 40.62% 37 Missing and 1 partial ⚠️
internal/querynodev2/delegator/delegator_data.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36208      +/-   ##
==========================================
+ Coverage   71.91%   81.16%   +9.24%     
==========================================
  Files        1059     1060       +1     
  Lines      139495   139553      +58     
==========================================
+ Hits       100322   113269   +12947     
+ Misses      34892    22008   -12884     
+ Partials     4281     4276       -5     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.34% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/delegator/delegator_data.go 88.56% <66.66%> (-0.12%) ⬇️
...l/querynodev2/delegator/delegator_delta_forward.go 40.62% <40.62%> (ø)

... and 235 files with indirect coverage changes

@sre-ci-robot sre-ci-robot merged commit 13d443e into milvus-io:2.4 Sep 12, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/36189 branch September 13, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants